• Paul Warren's avatar
    Fix handling of packets that are too short to be valid - Frédéric Perrin <fperrin@brocade.com> · 3fae1acf
    Paul Warren authored
    When packets that are too short to be valid IP packets happen to start
    with 0x45 or 0x60, iftop will still try to read source and destination
    addresses, which will usually just be random garbage.
    
    Note the assumption about what libpcap guarantees in the comments to
    handle_ip_packet():
    
        * It is assumed that the snaplen (currently hard-coded to 1000) is
        * big enough to always capture the IP header past the L2 encap, and
        * that pcap never truncates the packet to less than snaplen; in
        * other words, that pcaphdr->caplen = MIN(pcaphdr->len, snaplen).
    3fae1acf